[pve-devel] [PATCH v2 qemu-server 03/12] Add CPUConfig file and migrate some CPU helpers

[Stefan Reiter]

On 10/1/19 6:12 PM, Thomas Lamprecht wrote:
> On 9/30/19 12:58 PM, Stefan Reiter wrote:
>> The package will be used for custom CPU models as a SectionConfig, hence
>> the name. For now we simply move some CPU related helper functions and
>> declarations over from QemuServer to reduce clutter there.
> 
> Single thing I'm not too sure is how "qemu_machine_feature_enabled" fit's
> into the CPUConfig here..
> AFAICT, this rather looks like and attempt to avoid a cyclic module
> dependency?

Pretty much, yes. I don't think it looks *too* amiss.

> 
> Maybe we could also do a Machine module which then includes stuff like:
> machine_type_is_q35
> get_basic_machine_info
> 
> But seems not really worth it... better ideas?
> 

No great ideas, but should I leave it this way for v3 or work something out?

>>
>> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
>> ---
>>   PVE/QemuServer.pm           | 242 +---------------------------------
>>   PVE/QemuServer/CPUConfig.pm | 251 ++++++++++++++++++++++++++++++++++++
>>   PVE/QemuServer/Makefile     |   1 +
>>   3 files changed, 256 insertions(+), 238 deletions(-)
>>   create mode 100644 PVE/QemuServer/CPUConfig.pm
>>