[pve-devel] [PATCH installer 1/6] fixup 4kn install support

[Thomas Lamprecht]

On 11/29/19 11:53 AM, Stoiko Ivanov wrote:
> address 2 improvments suggested by Fabian.
> 

"fixup" sounds really like you broke something, not like small 
code refactoring/cleanup - please avoid too "clickbaity" subjects
(they are scaring me unnecessarily if a release nears ;) )

> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  proxinstall | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/proxinstall b/proxinstall
> index 399faa4..911ee3d 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -1767,14 +1767,11 @@ _EOD
>  		syscmd("chroot $targetdir /usr/sbin/update-initramfs -c -k $kapi") == 0 ||
>  		    die "unable to install initramfs\n";
>  
> -		my $native_4k_disk_bootable = 0;
> -		foreach my $di (@$bootdevinfo) {
> -		    $native_4k_disk_bootable |= ($di->{logical_bsize} == 4096);
> -		}
> +		my $native_4k_boot_disk_found = grep { $_->{logical_bsize} == 4096} @$bootdevinfo;
>  
>  		foreach my $di (@$bootdevinfo) {
>  		    my $dev = $di->{devname};
> -		    if (!$native_4k_disk_bootable) {
> +		    if (!$native_4k_boot_disk_found) {
>  			eval {
>  			    syscmd("chroot $targetdir /usr/sbin/grub-install --target i386-pc --no-floppy --bootloader-id='proxmox' $dev") == 0 ||
>  				    die "unable to install the i386-pc boot loader on '$dev'\n";
>