[pve-devel] [PATCH installer 0/6] small improvements for pre-used disks

[Stoiko Ivanov]

This patchset contains a few small improvements that came up during the review
of the 4kn support (in order of importance):
* check and warn for existing ESPs on disks, which are not used for the
  installation (and thus not cleared) if the system is booted in UEFI mode
* check and warn if any disk looks as if it's part of a ZFS-pool rpool
* move the check for a preexisting VG named pve/pmg to the hd-selection view
  instead of before creating the LVs (that way users don't need to run through
  the full installer to notice that something needs to be changed
* the suggestions of Fabian I oversaw (Thanks!)
* unmount the testdir recursively in the check-pve, check-pmg and clean targets
  (preventing the deletion of a bindmounted /proc, /sys, /dev if the check is
  aborted early

I checked how to put the EFI bootloader at first place after we installed it
but noticed that this already happens (`man bootctl`, and test-installs with
systemd-boot and grub (which replaces the exisiting 'proxmox' boot-id)

The check for existing ESPs and rpools is displayed only as warning, and can
either be ignored or the installation can be aborted.
This is mostly to not let users destroy their important data with one click
on a dialog-box.

A potential improvement for zfs-pools would be to try to import the pool with
a different name and export it (a.k.a rename it), however this would fail if
you the pool is not importable (e.g. you only put in one disk of a RAIDZ
into the box to be set up). The alternative could be to run `zpool labelclear`
on the devices (but this would again potentially destroy data).

One thing that came to my mind as a potentially nice UX for really clearing
all disks (and doing so knowingly) might be a dedicated GRUB target
('Wipe All Disks'), which starts proxinstall and runs a clear_disk on all disks
found after you confirm. (But this would be a future improvement)


Stoiko Ivanov (6):
  fixup 4kn install support
  umount testdir recursively in check-* targets
  warn users about existing ESPs on unused disks
  warn on existing rpool if installing on ZFS
  ask for renaming of existing pmg/pve VGs early
  move vgrename check to other sanitychecks

 Makefile       |   3 +
 debian/control |   2 +
 proxinstall    | 230 +++++++++++++++++++++++++++++++++----------------
 3 files changed, 163 insertions(+), 72 deletions(-)

-- 
2.20.1