[pve-devel] [PATCH storage] rbd: don't attempt to update features of snapshots

Fabian Grünbichler f.gruenbichler at proxmox.com
Fri Nov 29 10:57:17 CET 2019


it does not work:

disable RBD image features this kernel RBD drivers is not compatible with: fast-diff,object-map,deep-flatten
clone failed: could not disable krbd-incompatible image features 'fast-diff,object-map,deep-flatten' for rbd image: vm-123123123-disk-0 at test: rbd: snapshot name specified for a command that doesn't use it

Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---
triggered by creating a linked clone of a VM snapshot.

 PVE/Storage/RBDPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
index eb1f9a0..10b54e5 100644
--- a/PVE/Storage/RBDPlugin.pm
+++ b/PVE/Storage/RBDPlugin.pm
@@ -589,7 +589,7 @@ sub map_volume {
 
     return $kerneldev if -b $kerneldev; # already mapped
 
-    $krbd_feature_update->($scfg, $storeid, $name);
+    $krbd_feature_update->($scfg, $storeid, $name) if !$snapname;
 
     my $cmd = &$rbd_cmd($scfg, $storeid, 'map', $name);
     run_rbd_command($cmd, errmsg => "can't map rbd volume $name");
-- 
2.20.1





More information about the pve-devel mailing list