[pve-devel] [PATCH v3 pve-manager 4/4] add sdn gui

[Thomas Lamprecht]

On 11/26/19 3:20 PM, Alexandre Derumier wrote:
> ---
>  www/manager6/Makefile                      |  17 +++
>  www/manager6/Makefile.rej                  |   9 ++
>  www/manager6/StateProvider.js              |   4 +-
>  www/manager6/Utils.js                      |  70 +++++++++
>  www/manager6/Workspace.js                  |   1 +
>  www/manager6/dc/Config.js                  |  33 +++++
>  www/manager6/dc/PoolEdit.js                |  13 +-
>  www/manager6/form/SDNControllerSelector.js |  52 +++++++
>  www/manager6/form/SDNZoneSelector.js       |  52 +++++++
>  www/manager6/sdn/Browser.js                |  49 +++++++
>  www/manager6/sdn/ControllerView.js         | 146 +++++++++++++++++++
>  www/manager6/sdn/Status.js                 |  36 +++++
>  www/manager6/sdn/StatusView.js             |  98 +++++++++++++
>  www/manager6/sdn/VnetEdit.js               | 143 ++++++++++++++++++
>  www/manager6/sdn/VnetView.js               | 159 +++++++++++++++++++++
>  www/manager6/sdn/ZoneContentView.js        | 105 ++++++++++++++
>  www/manager6/sdn/ZoneView.js               | 158 ++++++++++++++++++++
>  www/manager6/sdn/controllers/Base.js       |  73 ++++++++++
>  www/manager6/sdn/controllers/EvpnEdit.js   |  55 +++++++
>  www/manager6/sdn/zones/Base.js             |  73 ++++++++++
>  www/manager6/sdn/zones/EvpnEdit.js         |  64 +++++++++
>  www/manager6/sdn/zones/QinQEdit.js         |  63 ++++++++
>  www/manager6/sdn/zones/VlanEdit.js         |  49 +++++++
>  www/manager6/sdn/zones/VxlanEdit.js        | 106 ++++++++++++++
>  www/manager6/tree/ResourceTree.js          |   4 +
>  25 files changed, 1630 insertions(+), 2 deletions(-)
>  create mode 100644 www/manager6/Makefile.rej
>  create mode 100644 www/manager6/form/SDNControllerSelector.js
>  create mode 100644 www/manager6/form/SDNZoneSelector.js
>  create mode 100644 www/manager6/sdn/Browser.js
>  create mode 100644 www/manager6/sdn/ControllerView.js
>  create mode 100644 www/manager6/sdn/Status.js
>  create mode 100644 www/manager6/sdn/StatusView.js
>  create mode 100644 www/manager6/sdn/VnetEdit.js
>  create mode 100644 www/manager6/sdn/VnetView.js
>  create mode 100644 www/manager6/sdn/ZoneContentView.js
>  create mode 100644 www/manager6/sdn/ZoneView.js
>  create mode 100644 www/manager6/sdn/controllers/Base.js
>  create mode 100644 www/manager6/sdn/controllers/EvpnEdit.js
>  create mode 100644 www/manager6/sdn/zones/Base.js
>  create mode 100644 www/manager6/sdn/zones/EvpnEdit.js
>  create mode 100644 www/manager6/sdn/zones/QinQEdit.js
>  create mode 100644 www/manager6/sdn/zones/VlanEdit.js
>  create mode 100644 www/manager6/sdn/zones/VxlanEdit.js
> 


You added quite a lot already, nice! The origin of the DC -> SDN section seems
to be the permission one, at least judging from the icons :P

If I try to create a zone I get:
> create sdn zone object failed: error with cfs lock 'file-sdn_zones_cfg_new': unable to open file '/etc/pve/sdn/zones.cfg.new.tmp.863023' - No such file or directory

We need to setup the (empty) /etc/pve/sdn directory to "fix" that, there's
a method in cluster somewhere where all those get created on pmxcfs start.

Also lacking permissions are not shown, i.e., I forgot to build access-control
with the new SDN.* permissions and while I could create a zone, I just saw
an empty list (the developer view then made me notice the 500 errors I got)
but that's probably irrelevant and bikeshedding at this point..

I'm a bit reluctant to add the Webinterface integration now as is, I'd first
also make it optional (i.e., hidden if pve-network is not installed - I can
see if I can implement this). Then I'd be great to have some (or at least one
^^) HowTo's, written for people with limited experience with this, to get them
to a simple/basic but functional setup, using this interface. I know, I know,
a lot to ask :) But I think this will really help people to use it.