[pve-devel] applied: [PATCH widget-toolkit 1/1] NetworkView: add apply config button

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 26 12:15:26 CET 2019


On 10/29/19 12:08 PM, Dominik Csapak wrote:
> when the host has ifupdown2 installed, we can hot apply the config
> add a button to do this
> 
> if the user does not meet the requirements, the api call
> will show why and throw an error (without changing anything)
> 
> the button has to be enabled via 'showApplyBtn', because for now,
> we do not want it for pmg
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> i am not entirely happy with the changed gettext for the reboot,
> but did not find a better one (suggestions welcome)
> 


applied, thanks! Followed-up with:
* adding confirm message
* using a '-' line separator instead of spaces between the button groups
* also disabling the Revert button if there are no changes
* change the text to:
"Either reboot or use 'Apply Configuration' (needs ifupdown2) to activate"




More information about the pve-devel mailing list