[pve-devel] [PATCH v2 qemu-server 2/2] fix #2367: do not allow snapshot with name PENDING

[Thomas Lamprecht]

On 10/24/19 1:53 PM, Oguz Bektas wrote:
> or any other variant of the word 'pending'.
> 
> note that we can actually allow this snapshot after PVE 7.0, since
> pending section and snapshots will be properly namespaced.
> ([pve:pending] and [snap:$snapname] or similar).
> 
> Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> ---
>  PVE/QemuServer.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 8d7994e..3669643 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2773,7 +2773,10 @@ sub write_vm_config {
>      &$cleanup_config($conf->{pending}, 1);
>  
>      foreach my $snapname (keys %{$conf->{snapshots}}) {
> -	die "internal error" if $snapname eq 'pending';
> +	# TODO: we can allow snapshots with name 'pending' after PVE 7.0

this is wrong, you can theoretically have a PENDING now and it can
be kept in ther until a VM gets live-migrated to 7.0 ...

> +	# since pending section is namespaced with 'pve:'
> +	# but for now, we should forbid it to avoid confusion in parser
> +	die "internal error: snapshot name '$snapname' is forbidden" if lc($snapname) eq 'pending';
>  	&$cleanup_config($conf->{snapshots}->{$snapname}, undef, $snapname);
>      }
>  
>