[pve-devel] applied-series: [PATCH v2 cluster 1/3] pvecm: fix weirdly spaced double-prompt for password on join

Fabian Grünbichler f.gruenbichler at proxmox.com
Fri Nov 22 09:16:44 CET 2019


applied whole series, thanks!

On November 19, 2019 10:28 am, Stefan Reiter wrote:
> Not only did it display two prompts with identical meaning, the second
> was indented to the end of the first in my terminal for some reason.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
> 
> Series is already based on Fabian's refactoring (i.e. latest master).
> 
> v2:
> * Move variable definitons with assert_joinable 2/3
> * Rename $silent -> $noerr in 3/3
> 
>  data/PVE/CLI/pvecm.pm | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm
> index d3fde3c..c13d0e7 100755
> --- a/data/PVE/CLI/pvecm.pm
> +++ b/data/PVE/CLI/pvecm.pm
> @@ -365,8 +365,7 @@ __PACKAGE__->register_method ({
>  	my $worker = sub {
>  
>  	    if (!$param->{use_ssh}) {
> -		print "Please enter superuser (root) password for '$host':\n";
> -		my $password = PVE::PTY::read_password("Password for root\@$host: ");
> +		my $password = PVE::PTY::read_password("Please enter superuser (root) password for '$host': ");
>  
>  		delete $param->{use_ssh};
>  		$param->{password} = $password;
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 




More information about the pve-devel mailing list