[pve-devel] [PATCH installer 1/2] Remove unused hdsize from zfs advanced options

Fabian Ebner f.ebner at proxmox.com
Thu Nov 21 13:35:01 CET 2019


On 11/21/19 12:48 PM, Thomas Lamprecht wrote:
> On 11/21/19 12:35 PM, Fabian Ebner wrote:
>> When a zpool is created the whole disks are used, so a user cannot set a size
>> limit in this case.
>>
> 
> are you sure?? AFAICR, this was added to ZFS so that one can leave some
> free space to add a swap device outside from ZFS (which made issues in
> the past)
> 

Sorry, my mistake. I was confused since with RAID0 the limit is only 
used for the boot disk. With a 16G and a 32G disk and hdsize 10G, after 
installing the 16G disk has BIOS+EFI+ZFS (1M + 512M + 9.5G) and the 
other has a ZFS partition+ZFS reserved (32G + 8M).

>> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
>> ---
>>   proxinstall | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/proxinstall b/proxinstall
>> index 5d02b34..93a61cb 100755
>> --- a/proxinstall
>> +++ b/proxinstall
>> @@ -2877,7 +2877,6 @@ my $create_raid_advanced_grid = sub {
>>       $spinbutton_copies->set_value($config_options->{copies});
>>       push @$labeled_widgets, "copies", $spinbutton_copies;
>>   
>> -    push @$labeled_widgets, "hdsize", $get_hdsize_spinbtn->();
>>       return &$create_label_widget_grid($labeled_widgets);;
>>   };
>>   
>>
> 




More information about the pve-devel mailing list