[pve-devel] [PATCH storage] fix #2467 remove duplicate volumes & tag with correct content type

Dominic Jäger d.jaeger at proxmox.com
Wed Nov 20 10:58:37 CET 2019


On Wed, Nov 20, 2019 at 09:09:12AM +0100, Fabian Ebner wrote:
> On 11/19/19 12:05 PM, Tim Marx wrote:
> > The bugfix for #2317 introduced a kind of odd api behavior, where each volume

While Tim's patch does indeed fix the API, I agree with Fabian's objections:

> Isn't it necessary to do this filtering inside 'list_volumes' and
> probably even for each volume?
> Otherwise for a storage with content types rootdir and images:
> 'pvesm list local-lvm --content rootdir' doesn't list anything and
> 'pvesm list local-lvm --content images' lists both container rootdirs
> and VM images.
> 

Why does `pvesm list local-iso --content images` actually list container data?
According to our wiki content type images is "KVM-Qemu VM images" which containers are not.
So currently the set of container images is a subset of VM images and there is no (easy) way to get the set VM images minus container images?




More information about the pve-devel mailing list