[pve-devel] [PATCH qemu-server] print_vga_device: fix qxl displays on Linux guests

[Aaron Lauterer]

On 11/19/19 4:13 PM, Thomas Lamprecht wrote:
> On 11/19/19 4:01 PM, Aaron Lauterer wrote:
>> with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
>> session to enable more displays on the fly in linux guests.
>>
>> Adding the `max_outputs` parameter to the qxl device manually restores
>> the functionality.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>>   PVE/QemuServer.pm                | 10 +++++++++-
>>   test/cfg2cmd/spice-usb3.conf.cmd |  2 +-
>>   2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index 11e7169..d05707d 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -2184,9 +2184,17 @@ sub print_vga_device {
>>   	$type = 'virtio-gpu';
>>       }
>>       my $vgamem_mb = $vga->{memory};
>> +
>> +    my $max_outputs = undef;
> 
> for windows guests I get:
> Use of uninitialized value $max_outputs in concatenation (.) or string at ../PVE/QemuServer.pm line 2229.
> (I added a test for win10 + spice now)
> 
> do:
> my $max_outputs = '';
> 
> instead.

duh... v2 is on the way :)