[pve-devel] [PATCH v4 0/8] Refactor QemuServer to avoid dependency cycles

Stefan Reiter s.reiter at proxmox.com
Tue Nov 19 13:33:46 CET 2019


On 11/19/19 12:34 PM, Thomas Lamprecht wrote:
> On 11/19/19 12:23 PM, Stefan Reiter wrote:
>> * fix and improve parse_cmdline (differentiate parameter '--foo' and '--foo 1',
>>    no ordering for now, I don't know if that ever makes in difference in QEMU?)
> 
> QEMU's command line is highly order-dependent of arguments, thus I
> explicitly do *not* sort those for my config2command test, as different
> ordering /may/ cause a regression, if that's what the question was.
> 

Just hadn't checked, for now parse_commandline will output parameters as 
a hash, so unordered. This is not an issue for current use cases, so I 
left it.




More information about the pve-devel mailing list