[pve-devel] [PATCH v2 qemu-server 5/6] close #2263: die on live migration with local cloudinit disk

Oguz Bektas o.bektas at proxmox.com
Mon Nov 18 15:41:14 CET 2019


From: Mira Limbeck <m.limbeck at proxmox.com>

Live migration with a local cloudinit disk was never intended to work. It did
however work to an extent that the migration completed but the disk on the
source node could not be deleted. Now die if a live migration is started with
a local cloudinit disk.

With the GUI changes live migration is already disabled as it recognizes the
cloudinit disk as a local resource.

Signed-off-by: Mira Limbeck <m.limbeck at proxmox.com>
(cherry picked from commit 9860fe4ef992e8550f8dee9aed65e2fed75c470f)
Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
---
 PVE/QemuMigrate.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 94bc40c..65f39b6 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -458,6 +458,7 @@ sub sync_disks {
 	    if ($self->{running} && $ref eq 'config') {
 		push @{$self->{online_local_volumes}}, $volid;
 	    } elsif ($ref eq 'generated') {
+		die "can't live migrate VM with local cloudinit disk. use a shared storage instead\n" if $self->{running};
 		# skip all generated volumes but queue them for deletion in phase3_cleanup
 		push @{$self->{volumes}}, $volid;
 		next;
-- 
2.20.1




More information about the pve-devel mailing list