[pve-devel] [PATCH qemu-server 1/9] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

[Oguz Bektas]

On Mon, Nov 18, 2019 at 10:21:06AM +0100, Thomas Lamprecht wrote:
> On 11/15/19 2:58 PM, Oguz Bektas wrote:
> > From: Christian Ebner <c.ebner at proxmox.com>
> > 
> > On some occasions e.g. license checking, the manufacturer string in the
> > SMBIOS settings edit has to allow characters such as whitespaces.
> > https://forum.proxmox.com/threads/proxmox-and-windows-rok-license-for-dell.53236/
> > In principle SMBIOS allows to pass any zero terminated string to the
> > corresponding fields in the structure type 1 (System Information).
> > 
> > By base64 encoding the values clashing of the config is avoided.
> > 
> > Relies on the corresponding patch to pve-manager to obtain base64 encoded values.
> > 
> > Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> > (cherry picked from commit 1f30ac3a9f18c215d3e3c657f9e81d9d3125f46c)
> > Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> > ---
> >  PVE/QemuServer.pm | 53 ++++++++++++++++++++++++++++++++++-------------
> >  1 file changed, 39 insertions(+), 14 deletions(-)
> > 
> 
> 
> Shortly discussed with Chris, we both think this should not be backported,
> it's not a bug fix, it's a whole new feature, people won't had setups
> where this broke and then got fixed again, and it would also needs the
> pve-manager patches... So please omit that (and my followup 2/9) from a
> v2, thanks!

ok