[pve-devel] [PATCH pve-guest-common 0/1] vzdump: added "includename" option which adds the name or hostname of a vm or container to a backup filename

[Marco Gabriel - inett GmbH]

Thanks for clarification.

I'd update the wiki page accordingly.

Best regards,
Marco


inett GmbH
>> Ihr IT Systemhaus in  Saarbrücken

Marco Gabriel
Geschäftsführer

t: 0681-410993-0
e: mgabriel at inett.de
www.inett.de

Technische Fragen:
Support E-Mail: support at inett.de
Support Hotline: 0681-410993-42


inett GmbH | Geschäftsführung: Marco Gabriel | Amtsgericht Saarbrücken HRB 16588
-----Ursprüngliche Nachricht-----
Von: Thomas Lamprecht <t.lamprecht at proxmox.com> 
Gesendet: Mittwoch, 13. November 2019 15:12
An: PVE development discussion <pve-devel at pve.proxmox.com>; Marco Gabriel - inett GmbH <mgabriel at inett.de>
Betreff: Re: [pve-devel] [PATCH pve-guest-common 0/1] vzdump: added "includename" option which adds the name or hostname of a vm or container to a backup filename

On 11/13/19 3:02 PM, Marco Gabriel wrote:
> *** BLURB HERE ***
> 
> Marco Gabriel (1):
>   vzdump: added "includename" option
> 
>  PVE/VZDump/Common.pm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

FYI, some pointers for sending patches with git/mail

It's nice if related patches are send together, even if they are from different repositories. This can be done with first using `git format-patch` and then do a single git send-email over all generated patches. For example, lets go to a few repos and format the most recent commit as patch to /tmp/patchq, then send it:

# cd pve-manager; git format-patch -s -o /tmp/patchq -1 # cd ../pve-guest-common; git format-patch -s -o /tmp/patchq -1 # cd ../pve-docs; git format-patch -s -o /tmp/patchq -1 # git send-email --compose --to=pve-devel at pve.proxmox.com /tmp/patchq/*

Using "start-number" and the like can improve this further, but it's a good start.

Another thing would is: if you do not fill out the cover letter, (see your BLURP HERE) anyway, it's better to omit it completely, which can be totally fine for small series or a single specific feature where the commit message(s) are enough, and no common overview or rationale is required to understand the goal and method used in a series.

Just a few pointer valid for anybody sending patches to developer mailing lists.

cheers,
Thomas