[pve-devel] [PATCH common/qemu-server/manager] fix #2436: do not hardcode pci domain

Dominik Csapak d.csapak at proxmox.com
Tue Nov 12 14:23:01 CET 2019


this series improves the pci passthrouh/selection code such that we
do not assume a pci domain of '0000' anymore. old configs still work,
and the 'default domain', 0000, will not be written out to the config
(but shown in the gui)

we can ignore the changes in qemus commandline, since such vms can
neither be migrated nor snapshotted

dependencies:

new qemu-server needs pve-common
new pve-manager needs pve-common
new pve-common breaks old manager and qemu-server

the only issue occurs if one wants to edit a vm on a not upgraded
cluster member (the selected id does then not exist in the store...)
can we ignore this? if not, i would send a v2 where i try to detect
the format we get from the backend and set the value in the selector
accordingly (but i am not sure if its worth the effort, since partially
upgrading a cluster is not recommended)

pve-common:

Dominik Csapak (1):
  SysFSTools: do not assume pci domain 0000

 src/PVE/SysFSTools.pm | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

qemu-server:

Dominik Csapak (1):
  fix #2436: pci: do not hardcode pci domain to 0000

 PVE/QemuServer.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

pve-manager:

Dominik Csapak (1):
  gui: pci passthrough: consider domain in PCISelector

 www/manager6/form/PCISelector.js |  2 +-
 www/manager6/qemu/PCIEdit.js     | 11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

-- 
2.20.1





More information about the pve-devel mailing list