[pve-devel] applied-series: [PATCH v4 ha-manager 0/5] Implement a stop command for HA

[Thomas Lamprecht]

On 10/10/19 12:25 PM, Fabian Ebner wrote:
> This patch series introduces a new 'stop' command for ha-manager.
> The command takes a timeout parameter and in case it is 0, it performs a hard stop.
> The series also includes a test for the new command.
> A few changes to how parameters were handled in CRM/LRM were necessary
> as well as allowing the service config to be updated from within the manager.
> 
> Changes from v3:
>     * Squashed and reordered as Thomas suggested

applied series, much thanks for this!

Made a minor followup adapting the log message, mainly I now
include the service ID so people can identify what gets stopped,
further I talk about "requesting" a stop (vs. already doing it),
as there are delays, so people can now that it was requested but
do not expect that it already happened (details, I know).
Also differ between "graceful stop" and "immediate hard-stop"
in the message, but that's just trivial message adaptions.

Single thing which was not to nice was the combined introduce
"crm-commands" and add stop command in one go, they should have
been split - but no biggie, so just ignored that.

Ah, and I squashed the test into the command which added the
functionality, so we can immediately test it :)

> 
> Fabian Ebner (5):
>   Add update_service_config to the HA environment interface and
>     simulation
>   Add timeout parameter for shutdown
>   Add crm command 'stop'
>   Introduce crm-command to CLI and add stop as a subcommand
>   Add test for the stop command
> 
>  src/PVE/CLI/ha_manager.pm                   | 46 +++++++++++++-
>  src/PVE/HA/Env.pm                           |  6 ++
>  src/PVE/HA/Env/PVE2.pm                      |  6 ++
>  src/PVE/HA/LRM.pm                           | 10 ++-
>  src/PVE/HA/Manager.pm                       | 27 ++++++--
>  src/PVE/HA/Resources.pm                     |  2 +-
>  src/PVE/HA/Resources/PVECT.pm               | 14 +++--
>  src/PVE/HA/Resources/PVEVM.pm               | 16 +++--
>  src/PVE/HA/Sim/Env.pm                       |  6 ++
>  src/PVE/HA/Sim/Hardware.pm                  | 22 +++++++
>  src/test/test-stop-command1/README          |  2 +
>  src/test/test-stop-command1/cmdlist         |  8 +++
>  src/test/test-stop-command1/hardware_status |  5 ++
>  src/test/test-stop-command1/log.expect      | 69 +++++++++++++++++++++
>  src/test/test-stop-command1/manager_status  |  1 +
>  src/test/test-stop-command1/service_config  |  6 ++
>  16 files changed, 227 insertions(+), 19 deletions(-)
>  create mode 100644 src/test/test-stop-command1/README
>  create mode 100644 src/test/test-stop-command1/cmdlist
>  create mode 100644 src/test/test-stop-command1/hardware_status
>  create mode 100644 src/test/test-stop-command1/log.expect
>  create mode 100644 src/test/test-stop-command1/manager_status
>  create mode 100644 src/test/test-stop-command1/service_config
>