[pve-devel] [PATCH manager] add graphite tcp support

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 7 08:16:22 CET 2019


Hi,

On 11/7/19 8:08 AM, Martin Verges wrote:
> I agree that we don't read from that socket, therefore
> "$carbon_socket->read_timeout($timeout);" should not be required. However,
> I don't know how perl works internally and therefore I think it won't hurt
> to set read and write to prevent any blocking. Maybe someone with better
> knowledge about perl and pvestatd should answer that.
> 

It's not directly dependent of perl and pvestatd itself, this is just a
module hooking into the send methods and adding timeouts. Just was
interested if you had specific reasons for that :)
But I kept it, as it really does not hurts to have here.

Thank you again for your contribution.

cheers,
Thomas




More information about the pve-devel mailing list