[pve-devel] applied-series: [PATCH docs v2 00/10] pveceph: update doc

[Thomas Lamprecht]

On 11/6/19 3:09 PM, Alwin Antreich wrote:
> In patch 10 I have added an attribute to asciidoc-pve.conf to replace
> Ceph's codename. I hope this is the right location for this.

applied series, but dropped all screenshots. They were not made with
our selenium/remote driver based end-to-end+screenshot tooling, so they
visually stand out to much and are not reproducible anymore..
(new one should be directly made with that, old ones not already made
with that should be phased out)

Also, IMO, all but the "Manager Create" one were a bit superfluous,
as there was already a scrot for that panel and adding a new one with
just the remove button focuses (which is *very* subtle, IMO) does not
really brings additional value - it's already simple enough to describe
in text form, and as said, one panel screenshot is enough then.

As this are binary changes, and would have bloat the .git object
folder ub by almost 10% I amended each patch and dropped them
directly, to avoid .git bloat.
The intention was good, and it would be nice if we could get a
reproducible one with the pve-experimental/pve-gui-tests project.

Also did some light followups, may make sense to give them a second
look.

Thanks!

> 
> Changes V1 -> V2:
>     Added corrections and suggestions from Aaron.
>     Doesn't ship the applied patch "pveceph: old style commands to subcommands"
> 
> Review and suggestions are very welcome. Thanks. :)
> 
> Alwin Antreich (10):
>   pveceph: add section - Destroying Ceph OSDs
>   pveceph: add section - Destroying Ceph Monitor
>   pveceph: add Ceph Monitor screenshot
>   pveceph: add section - Destroying Ceph Manager
>   pveceph: add section - Destroying Ceph Pools
>   pveceph: switch note for Creating Ceph Manager
>   pveceph: Reorganize TOC for new sections
>   pveceph: correct CephFS subtitle
>   Fix #1958: pveceph: add section Ceph maintenance
>   pveceph: add attribute ceph_codename
> 
>  pveceph.adoc                                  | 252 ++++++++++++++----
>  asciidoc/asciidoc-pve.conf                    |   1 +
>  .../screenshot/gui-ceph-manager-destroy.png   | Bin 0 -> 153596 bytes
>  images/screenshot/gui-ceph-manager.png        | Bin 0 -> 153389 bytes
>  .../screenshot/gui-ceph-monitor-destroy.png   | Bin 0 -> 154084 bytes
>  images/screenshot/gui-ceph-osd-destroy.png    | Bin 0 -> 146184 bytes
>  images/screenshot/gui-ceph-pools-destroy.png  | Bin 0 -> 141532 bytes
>  7 files changed, 205 insertions(+), 48 deletions(-)
>  create mode 100644 images/screenshot/gui-ceph-manager-destroy.png
>  create mode 100644 images/screenshot/gui-ceph-manager.png
>  create mode 100644 images/screenshot/gui-ceph-monitor-destroy.png
>  create mode 100644 images/screenshot/gui-ceph-osd-destroy.png
>  create mode 100644 images/screenshot/gui-ceph-pools-destroy.png
>