[pve-devel] [PATCH docs 02/11] pveceph: add section - Destroying Ceph OSDs

[Aaron Lauterer]

Some suggestions inline.

On 11/4/19 2:52 PM, Alwin Antreich wrote:
> Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
> ---
>   pveceph.adoc                               |  31 +++++++++++++++++++++
>   images/screenshot/gui-ceph-osd-destroy.png | Bin 0 -> 146184 bytes
>   2 files changed, 31 insertions(+)
>   create mode 100644 images/screenshot/gui-ceph-osd-destroy.png
> 
> diff --git a/pveceph.adoc b/pveceph.adoc
> index cfb86a8..d9c17c7 100644
> --- a/pveceph.adoc
> +++ b/pveceph.adoc
> @@ -358,6 +358,37 @@ Starting with Ceph Nautilus, {pve} does not support creating such OSDs with
>   ceph-volume lvm create --filestore --data /dev/sd[X] --journal /dev/sd[Y]
>   ----
>   
> +Destroying Ceph OSDs
> +--------------------
> +
> +[thumbnail="screenshot/gui-ceph-osd-destroy.png"]
> +
> +To remove an OSD on the GUI, go to a PVE host under **Ceph -> OSD** and select
> +the OSD you want to destroy. Then click on the **OUT** button and once the OSD
> +is out, on the **STOP** button. After the OSD is out & down, you can select
> +**Destroy** from the More drop-down menu.

To remove an OSD via the GUI first select the {PVE} node in the tree 
view. Select the **Ceph -> OSD** panel and select the OSD to destroy. 
Next click the **OUT** button. Once the OSD's status changed from `in` 
to `out` click the **STOP** button. As soon as the status changed from 
up to down select **Destroy** from the `More` drop-down menu.

> +
> +On the CLI issue the commands below to destroy a running OSD.

To remove an OSD via the CLI run the following commands.

> +
> +The first command tells Ceph to not include the OSD in data distribution
> +anymore. The second stops the OSD service. Up to this point no data is lost and
> +if the wrong OSD was specified, it can be reverted.

# I would move this to the beginning of the chapter. Explaining the 
involved steps like setting the OSD to out, then down  / systemctl stop 
and then destroying it because that information is relevant for both 
variants (GUI/CLI).

> +
> +[source,bash]
> +----
> +ceph osd out <ID>
> +systemctl stop ceph-osd@<ID>.service
> +----
> +
> +The following command destroys the OSD. Specify the '-cleanup' option to
> +additionally destroy the partition table.
> +[source,bash]
> +----
> +pveceph osd destroy <ID>
> +----
> +WARNING: The above command will destroy data on the disk!
> +
> +