[pve-devel] applied: [PATCH v7 manager 3/3] added basic ability to install ceph via gui

[Thomas Lamprecht]

Am 3/6/19 um 12:29 PM schrieb Tim Marx:
> Signed-off-by: Tim Marx <t.marx at proxmox.com>
> ---
> 
> changes v7:
> * no back button
> * display error if error isn't expected while install
> * fix store error on close
> * fix code style errors
> * fix typos
> * use load event
> * changed store to updateStore
> * moved reusable code to utils
> * changed regex
> 
>  www/css/ext6-pve.css                   |   5 +
>  www/manager6/Makefile                  |   3 +
>  www/manager6/Utils.js                  |  46 ++++++
>  www/manager6/ceph/CephInstallWizard.js | 267 +++++++++++++++++++++++++++++++++
>  www/manager6/ceph/Config.js            |   9 ++
>  www/manager6/ceph/Crush.js             |   8 +
>  www/manager6/ceph/FS.js                |  24 ++-
>  www/manager6/ceph/Log.js               |  60 ++++++++
>  www/manager6/ceph/Monitor.js           |  13 +-
>  www/manager6/ceph/OSD.js               |   9 +-
>  www/manager6/ceph/Pool.js              |  12 +-
>  www/manager6/ceph/Status.js            |  13 +-
>  www/manager6/node/Config.js            |   5 +-
>  www/manager6/window/CephInstall.js     |  66 ++++++++
>  14 files changed, 532 insertions(+), 8 deletions(-)
>  create mode 100644 www/manager6/ceph/CephInstallWizard.js
>  create mode 100644 www/manager6/ceph/Log.js
>  create mode 100644 www/manager6/window/CephInstall.js
> 


so I just applied this with Dominik's R-b, it would be great if you send a separate
patch for the few nits I commented off-list. Additionally Dominik's idea for a direct
xterm.js use, without an iframe involved would be great to look into, we could possibly
use it do improve the "activate Next button" during installation logic, if it seems
reasonable and improves things it would be great if you could follow up on with it.

That said, much thanks for this, nice work!