[pve-devel] [PATCH v7 manager 0/3] add pveceph install to gui

Dominik Csapak d.csapak at proxmox.com
Fri Mar 8 10:41:11 CET 2019


looks good to me

one thing that is not a blocker but maybe something to think about:

maybe it would be better to use xterm.js directly,
instead of using it in the iframe? (also for the integrated console)

this could be better stylewise and it would probably enable us
to look for the correct state for the next button

else:

Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>



More information about the pve-devel mailing list