[pve-devel] applied: [PATCH pve-network 0/2] improvments

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jun 6 08:32:24 CEST 2019


On 6/6/19 8:20 AM, Alexandre Derumier wrote:
> - fix multicast vxlan default mtu. (should be 50 bytes lower than physdev)
> - clean status sub from Thomas comments
> 
> Alexandre Derumier (2):
>   vxlanmulticast : fix mtu
>   cleanup status sub
> 
>  PVE/Network/Network.pm                      | 13 ++++++++-----
>  PVE/Network/Network/VlanPlugin.pm           |  3 +--
>  PVE/Network/Network/VxlanMulticastPlugin.pm |  7 +++++--
>  test/generateconfig.pl                      |  3 ++-
>  4 files changed, 16 insertions(+), 10 deletions(-)
> 

applied, thanks! 

On another note, is there any specific reason we have a double "Network"
in the module namespace? Or could we change it to

PVE/Network.pm
PVE/Network/VlanPlugin.pm
...

and respective module name-path changes? As now, with not much external 
code using this, it would be still relatively easy to change.. I mean
it's nothing to important, but it irked me a little bit a few times ^^
I could do the change, if you agree and have no objections :-)

cheers,
Thomas




More information about the pve-devel mailing list