[pve-devel] applied: [PATCH manager] fix #2265: enable discard for virtio-blk

[Thomas Lamprecht]

On 7/10/19 12:29 PM, Stefan Reiter wrote:
> QEMU 4.0 supports this. Guest needs to have at least Kernel 5.0 for it
> to be used.
> 
> SSD emulation is still not supported AFAICT, so no change here.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
> 
> The 'SSD emulation' checkbox is interesting, since 'rotation_rate' (which it
> changes) is not only not supported on virtio-blk, but seemingly only works on
> virtio-scsi and IDE. QEMU's SATA implementation has no mention that I could
> find, but it also doesn't seem to break it, so I left it as is for now.
> 
>  www/manager6/qemu/HDEdit.js | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index 0cabb598..46397d37 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -25,10 +25,8 @@ Ext.define('PVE.qemu.HDInputPanel', {
>  	    }
>  
>  	    var virtio = value.match(/^virtio/);
> -	    this.lookup('discard').setDisabled(virtio);
>  	    this.lookup('ssd').setDisabled(virtio);
>  	    if (virtio) {
> -		this.lookup('discard').setValue(false);
>  		this.lookup('ssd').setValue(false);
>  	    }
>  
> @@ -258,7 +256,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
>  	    {
>  		xtype: 'proxmoxcheckbox',
>  		fieldLabel: gettext('Discard'),
> -		disabled: me.confid && me.confid.match(/^virtio/),
>  		reference: 'discard',
>  		name: 'discard'
>  	    }
> 

applied, thanks!