[pve-devel] [PATCH manager] fix #2265: enable discard for virtio-blk

[Nick Chevsky]

On Wed, Jul 10, 2019, 5:29 AM Stefan Reiter <s.reiter at proxmox.com> wrote:

> The 'SSD emulation' checkbox is interesting, since 'rotation_rate' (which
> it changes) is not only not supported on virtio-blk, but seemingly only
> works on virtio-scsi and IDE. QEMU's SATA implementation has no mention
> that I could find, but it also doesn't seem to break it, so I left it as is
> for now.


QEMU's "ide-hd" code path (which is really a misnomer for ATA) implements
this for both "IDE" and "SATA" drives as we refer to them in Proxmox.

I did extensive research on this when I implemented the "SSD emulation"
flag. For background, see the links and code referenced in:

https://git.proxmox.com/?p=qemu-server.git;a=commit;h=6c875f9f315f2dc7a0a3a988622c2efdf089b171

Nick