[pve-devel] applied: [PATCH manager 2/2] ceph destroymon: actually die on errors

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jul 17 13:02:38 CEST 2019


On 7/16/19 3:51 PM, Fabian Grünbichler wrote:
> instead of silently ignoring them. since we are in a task worker here
> this is especially important - otherwise the task status/result is also
> wrong!
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
>  PVE/API2/Ceph/MON.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
> index 2ad2b71e..e363c08c 100644
> --- a/PVE/API2/Ceph/MON.pm
> +++ b/PVE/API2/Ceph/MON.pm
> @@ -411,6 +411,8 @@ __PACKAGE__->register_method ({
>  		warn $@ if $@;
>  		PVE::Ceph::Services::broadcast_ceph_services();
>  	    });
> +
> +	    die $@ if $@;
>  	};
>  
>  	return $rpcenv->fork_worker('cephdestroymon', $monsection,  $authuser, $worker);
> 

applied, thanks!





More information about the pve-devel mailing list