[pve-devel] [PATCH manager 2/2] ceph destroymon: actually die on errors

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Jul 16 15:51:04 CEST 2019


instead of silently ignoring them. since we are in a task worker here
this is especially important - otherwise the task status/result is also
wrong!

Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---
 PVE/API2/Ceph/MON.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index 2ad2b71e..e363c08c 100644
--- a/PVE/API2/Ceph/MON.pm
+++ b/PVE/API2/Ceph/MON.pm
@@ -411,6 +411,8 @@ __PACKAGE__->register_method ({
 		warn $@ if $@;
 		PVE::Ceph::Services::broadcast_ceph_services();
 	    });
+
+	    die $@ if $@;
 	};
 
 	return $rpcenv->fork_worker('cephdestroymon', $monsection,  $authuser, $worker);
-- 
2.20.1





More information about the pve-devel mailing list