[pve-devel] [PATCH manager] gui: node disks: show if an osd is encrypted

[Thomas Lamprecht]

On 7/16/19 2:46 PM, Dominik Csapak wrote:
> On 7/16/19 12:20 PM, Tim Marx wrote:
>> I would prefer a new column, because I don't like these string extensions which probably aren't visible anyway if the column is to small.
> 
> yeah makes sense, what about a general 'encryption' column where we only show it (atm) for osds and leave it empty for other usages?
> this way we do not have false positives for other uses we do not check (e.g. zfs)

sounds OK for me.

>>
>> Regarding the code, maybe you could use template-strings e.g. `Ceph osd.${data.osdid} ${tagtext}`?
> yes, i was not sure about browser support, but https://caniuse.com/#feat=template-literals shows support for most current browsers
> 
> any other opinions? @Thomas?

It seems all browser and their versions we care for in 6.X have support,
so at least no technical blocker. Personally I'm not really used to them
but are pretty neutral regarding that syntax.. For non-gettexts they're
probably OK to have.