[pve-devel] [PATCH manager] gui: node disks: show if an osd is encrypted

Dominik Csapak d.csapak at proxmox.com
Tue Jul 16 14:46:35 CEST 2019


On 7/16/19 12:20 PM, Tim Marx wrote:
> I would prefer a new column, because I don't like these string extensions which probably aren't visible anyway if the column is to small.

yeah makes sense, what about a general 'encryption' column where we only 
show it (atm) for osds and leave it empty for other usages?
this way we do not have false positives for other uses we do not check 
(e.g. zfs)

> 
> Regarding the code, maybe you could use template-strings e.g. `Ceph osd.${data.osdid} ${tagtext}`?
> 

yes, i was not sure about browser support, but 
https://caniuse.com/#feat=template-literals shows support for most 
current browsers


any other opinions? @Thomas?




More information about the pve-devel mailing list