[pve-devel] [PATCH manager] fix popup behaviour in firefox with touchscreens on desktop

Dominik Csapak d.csapak at proxmox.com
Thu Feb 21 11:34:25 CET 2019


when the popup blocker is active, nw is undefined and nw.focus() throws an
error and the touchend event is not finished, causing extjs to retry the
touchevent and click handler, which tries to open a popup which gets blocked
here, and so on

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/Utils.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index c96987e8..481b5186 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -881,7 +881,9 @@ Ext.define('PVE.Utils', { utilities: {
 	    resize: 'off'
 	});
 	var nw = window.open("?" + url, '_blank', "innerWidth=745,innerheight=427");
-	nw.focus();
+	if (nw) {
+	    nw.focus();
+	}
     },
 
     openSpiceViewer: function(url, params){
-- 
2.11.0




More information about the pve-devel mailing list