[pve-devel] [PATCH widget-toolkit] fix popup behaviour in firefox with touchscreens on desktop

Dominik Csapak d.csapak at proxmox.com
Thu Feb 21 11:34:24 CET 2019


when the popup blocker is active, nw is undefined and nw.focus() throws
an error and the touchend event is not finished, causing
extjs to retry the touchevent and click handler, which tries to open
a popup which gets blocked here, and so on

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 Utils.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Utils.js b/Utils.js
index db55996..dac5fb1 100644
--- a/Utils.js
+++ b/Utils.js
@@ -586,7 +586,9 @@ Ext.define('Proxmox.Utils', { utilities: {
 	    node: nodename
 	});
 	var nw = window.open("?" + url, '_blank', 'toolbar=no,location=no,status=no,menubar=no,resizable=yes,width=800,height=420');
-	nw.focus();
+	if (nw) {
+	    nw.focus();
+	}
     }
 
 },
-- 
2.11.0




More information about the pve-devel mailing list