[pve-devel] [PATCH v5 manager 0/5] add pveceph install to gui

Tim Marx t.marx at proxmox.com
Fri Feb 8 12:16:55 CET 2019

I added the install window to the remaining submenus.
This needed some changes regarding error handling to get the same
behavior for all subviews.

Only the manager repo got touched.

I addressed various inputs:

I headed back to my original approach and declare the cmd parameter 
in each api endpoint separately. This results again in only 4 repos
touched instead of 5. This change is reasoned by Thomas input [0].
I decided against a module level variable because I think it improves
the readability.

All repos since v2 are untouched except the pve-manager.
Changed some commit messages slightly.

[0] https://pve.proxmox.com/pipermail/pve-devel/2019-January/035358.html

In general I changed the approach from passing a command directly to
passing a command keyword which gets matched in the api and not
directly executed. Only the following two out of now 5 (v1 were 4) repos 
got changed since v1.

With this patch series and the corresponding patches in the following repositories
its now possible to install ceph via the gui in the same way as someone would if using the
pveceph install command manually

Affected repositories:

  * altered the ceph install check to check for the mon binary, 
    because the ceph binary is likely to be there already
  * added parameter to all 3 consoles (novnc,xterm,spice) to pass a custom command
  * in the gui the ceph status page checks if the not install error returns and 
    if so, shows a window which offers to install ceph

  * added new cmd paramater 
  * added new cmd paramater
  * added new cmd paramater

Tim Marx (5):
  unified the classification of the passed command for all shell apis
  deprecate old upgrade property
  add pveceph install to shell api
  added new parameter to pass a command to the newly opened terminal
  added basic ability to install ceph via gui

 PVE/API2/Nodes.pm                    | 97 +++++++++++++++++++++---------------
 www/css/ext6-pve.css                 |  5 ++
 www/manager6/Makefile                |  2 +
 www/manager6/Utils.js                | 50 ++++++++++++++++---
 www/manager6/button/ConsoleButton.js | 12 +++--
 www/manager6/ceph/Config.js          | 13 +++++
 www/manager6/ceph/Crush.js           | 12 +++++
 www/manager6/ceph/FS.js              | 36 ++++++++++++-
 www/manager6/ceph/Log.js             | 70 ++++++++++++++++++++++++++
 www/manager6/ceph/Monitor.js         | 16 +++++-
 www/manager6/ceph/OSD.js             | 19 ++++++-
 www/manager6/ceph/Pool.js            | 15 +++++-
 www/manager6/ceph/Status.js          | 18 ++++++-
 www/manager6/node/Config.js          |  5 +-
 www/manager6/window/CephInstall.js   | 57 +++++++++++++++++++++
 15 files changed, 366 insertions(+), 61 deletions(-)
 create mode 100644 www/manager6/ceph/Log.js
 create mode 100644 www/manager6/window/CephInstall.js


Tim Marx (1):
  novnc: added new parameter to pass a command to the newly opened

 .../patches/0012-pass-custom-command-to-vnc.patch  | 38 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 2 files changed, 39 insertions(+)
 create mode 100644 debian/patches/0012-pass-custom-command-to-vnc.patch


Tim Marx (1):
  xterm: added new parameter to pass a command to the newly opened

 src/www/main.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)


Tim Marx (1):
  widget: added new parameter to pass a command to the newly opened

 Utils.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

More information about the pve-devel mailing list