[pve-devel] [PATCH qemu-server 2/3] suspend to disk: check more permissions

Dominik Csapak d.csapak at proxmox.com
Fri Dec 6 11:10:52 CET 2019


>>
>> UX nit: we need to give the user the option to set a vmstatestorage on
>> the GUI now - otherwise this might reliably pick a storage that the user
>> cannot access, while there are other storages where they might be
>> allowed to allocate a vmstate volume but they don't get that choice.
>>
>> -> make vmstatestorage option editable on GUI
>> -> display a storage selector in hibernate dialogue, pre-select
>> vmstatestorage from config if set, allow any storages that the user can
>> access
> 
> I'd favour the latter but with the same logic fallback as the backend has,
> if no storage is set in the config. Naturally with the disallowed storage
> filtered out/marked invalid.
> 

counter-proposal:

with having the same logic in the backend and frontend,
we risk that they drift apart, making the ux not better..

also possibly pre-selecting a storage the user has no
rights to is bad ux (and selecting a different one
means that then the logic has to be different in the first place)

i would prefer that we document the automatic selection
(in the docs; including a help link on the dialog; and possibly in a 
tooltip)
and show the user a storage selection with only the storages he has
the correct permissions (via api call)
by default make the field empty and show 'automatic selection' or
something similar

this way, the default stays the same, but with the possibility
of the user selecting a storage he has privs to (without
selecting a storage by default that he cannot use)

we could then still expose the vmstate storage in the gui (options?)
if wanted/needed (this is also used for snapshots with ram,
so this would be useful either way)



More information about the pve-devel mailing list