[pve-devel] applied: [PATCH v2 manager] Delete "exclude" when switching a backup job to pool mode

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Aug 16 13:45:48 CEST 2019


Am 8/14/19 um 3:36 PM schrieb Stefan Reiter:
> If you updated a job in "exclude" mode with some VMIDs specified to "pool" mode,
> the backup job would retain the "exclude" section and thus not back up all VMs.
> 
> The GUI misrepresents this, showing that all VMs will be backed up or
> straight up break and show "exclude" mode again, with the backend still
> being on "pool" - to prevent this, we always delete a jobs "exclude" list
> when it's switched to "pool".
> 
> Co-authored-by: Tim Marx <t.marx at proxmox.com>
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  PVE/API2/Backup.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
> index 8bf3895f..0b69cc62 100644
> --- a/PVE/API2/Backup.pm
> +++ b/PVE/API2/Backup.pm
> @@ -469,6 +469,7 @@ __PACKAGE__->register_method({
>  		    } elsif ($job->{pool}) {
>  			delete $job->{vmid};
>  			delete $job->{all};
> +			delete $job->{exclude};
>  		    }
>  
>  		    PVE::VZDump::verify_vzdump_parameters($job, 1);
> 

applied, thanks!



More information about the pve-devel mailing list