[pve-devel] [PATCH v2 manager] Delete "exclude" when switching a backup job to pool mode

Stefan Reiter s.reiter at proxmox.com
Wed Aug 14 15:36:27 CEST 2019


If you updated a job in "exclude" mode with some VMIDs specified to "pool" mode,
the backup job would retain the "exclude" section and thus not back up all VMs.

The GUI misrepresents this, showing that all VMs will be backed up or
straight up break and show "exclude" mode again, with the backend still
being on "pool" - to prevent this, we always delete a jobs "exclude" list
when it's switched to "pool".

Co-authored-by: Tim Marx <t.marx at proxmox.com>
Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
---
 PVE/API2/Backup.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 8bf3895f..0b69cc62 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -469,6 +469,7 @@ __PACKAGE__->register_method({
 		    } elsif ($job->{pool}) {
 			delete $job->{vmid};
 			delete $job->{all};
+			delete $job->{exclude};
 		    }
 
 		    PVE::VZDump::verify_vzdump_parameters($job, 1);
-- 
2.20.1




More information about the pve-devel mailing list