[pve-devel] applied: [PATCH manager] pveceph: install ceph service print sucess message

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 16 14:07:16 CEST 2019


On 4/9/19 10:44 AM, Alwin Antreich wrote:
> This patch adds a success message on successful ceph.service
> installation. And adds a newline to make a successful ceph package
> installation more visible.
> 
> Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
> ---
>  PVE/CLI/pveceph.pm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
> index 831ad007..df59804f 100755
> --- a/PVE/CLI/pveceph.pm
> +++ b/PVE/CLI/pveceph.pm
> @@ -151,13 +151,18 @@ __PACKAGE__->register_method ({
>  
>  	if (PVE::Ceph::Tools::systemd_managed() && ! -e '/etc/systemd/system/ceph.service') {
>  	    #to disable old SysV init scripts.
> -	    print "replacing ceph init script with own ceph.service\n";
> +	    print "\nreplacing ceph init script with own ceph.service\n";
>  	    eval {
>  		PVE::Tools::run_command('cp -v /usr/share/doc/pve-manager/examples/ceph.service /etc/systemd/system/ceph.service');
>  		PVE::Tools::run_command('systemctl daemon-reload');
>  		PVE::Tools::run_command('systemctl enable ceph.service');
>  	    };
> -	    warn "could not install ceph.service\n" if $@;
> +	    my $err = $@;
> +	    if (!$err) {
> +		print "\ninstalled ceph.service successfully\n";
> +	    } else {
> +		warn "could not install ceph.service\n";
> +	    }
>  	}
>  
>  	return undef;
> 

applied, thanks!




More information about the pve-devel mailing list