[pve-devel] rfc : pve-network : idea to generate and reload config accross the nodes
Alexandre DERUMIER
aderumier at odiso.com
Mon Apr 1 08:50:51 CEST 2019
maybe better:
in gui, at network,datacenter level
at each change, make a
/etc/pve/networks/vnet.cfg.<randomversion>
on local node, the daemon detect the new version,make verification,
and update /etc/pve/nodes/<node>/.networkconfigstatus
version:<randomversion> verify:ok
Then at datacenter level, the apply button is grey-out by default,
if all local daemon verify version are ok (matching the vnet.cfg.<version>),
enable the apply button.
Then on apply,
mv /etc/pve/networks/vnet.cfg.<randomversion> /etc/pve/networks/vnet.cfg
and local node apply with new config and reload network
----- Mail original -----
De: "Alexandre Derumier" <aderumier at odiso.com>
À: "dietmar" <dietmar at proxmox.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Lundi 1 Avril 2019 07:48:07
Objet: Re: [pve-devel] rfc : pve-network : idea to generate and reload config accross the nodes
>>Can't we simply add a manual "apply" button for now?
Yes, I have thinked a little bit more about it.
But I really would like to have some kind of verification before apply.
>>Just by using backup config files:
>>
>>vnet.cfg.new
>>vnet.cfg
I'm not sure, as we could apply the change, the change is not apply on some nodes,
then we do other changes.
Maybe:
1) do a change in vnet.cfg
2) the local daemon, could compute the md5 of the vnet.cfg and test if it's ok
and store it in
/etc/pve/nodes/<node>/.networkconfigstatus.
(version:hash status:validateok)
3) then we are able to apply configuration
...
This will avoid the "test button", as the daemon is always doing it on config change in background.
----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Vendredi 29 Mars 2019 17:03:02
Objet: Re: rfc : pve-network : idea to generate and reload config accross the nodes
> I think it's better than blindly try to reload networkconfig on each change, as network is critical,
> and sometimes admin need to change multiple parameters and apply it once.
Can't we simply add a manual "apply" button for now? Just by using backup config files:
vnet.cfg.new
vnet.cfg
?
_______________________________________________
pve-devel mailing list
pve-devel at pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
More information about the pve-devel
mailing list