[pve-devel] [PATCH installer v3 0/7] don't create swap on ZFS as default

[Thomas Lamprecht]

On 11/23/18 12:52 PM, Fabian Grünbichler wrote:
> series LGTM, haven't built or tested a CD though.
> 

yeah, I tested applied it now, but followed up with a patch to remove the
newly introduced our usages, allows to reuse code a bit more.

> a followup for pve-docs in the installer section that mentions that ZFS
> does no longer setup swap and what to do in case you want to create it
> manually would be nice, as well as a short sentence in the
> yet-to-be-written 5.3 release notes.
yes agreed. @Stoiko, can you please take care of pve-docs?

> 
> On Thu, Nov 22, 2018 at 06:26:56PM +0100, Stoiko Ivanov wrote:
>> Changes from v2:
>> * Unify partitioning between ZFS and other (LVM, Btrfs) cases.
>> * Changes for the partitioning:
>>   * drop the 8M partition (number 9) at the end of the disk for ZFS
>>     (should people need to replace one disk by a slightly smaller one, they can
>>     shrink the efi-partition by this amount)
>>   * create the bios_boot partition from sectors 34:2047 (remaining space after
>>     the primary GPT)
>> * change in semantics: users can provide the `hdsize` parameter (size that is
>>   used), instead of minfree (size that is left unpartitioned).
>> * fixed a typo in an error-message
>> * readd the patch to use truncate instead of dd for the test.img creation
>>
>> Stoiko Ivanov (7):
>>   Unify and adapt disk partitioning
>>   Remove partition_bootable_zfs_disk
>>   Refactor $maxhdsize computation
>>   Fix typo in error message.
>>   Add hdsize spinbutton to ZFS grid
>>   Do not create a swap zvol
>>   buildsys: use truncate to create test.img
>>
>>  Makefile    |   2 +-
>>  proxinstall | 139 ++++++++++++++----------------------------------------------
>>  2 files changed, 33 insertions(+), 108 deletions(-)
>>
>> -- 
>> 2.11.0