[pve-devel] [PATCH manager 2/6 v2] Scan.pm: add mdev scan api call

Wolfgang Bumiller w.bumiller at proxmox.com
Thu Nov 22 13:49:34 CET 2018


On Thu, Nov 22, 2018 at 08:27:58AM +0100, Thomas Lamprecht wrote:
> On 11/20/18 5:13 PM, Dominik Csapak wrote:
> > this is for the gui to be able to select mediated devices
> 
> why not a scan/pci/{pci-id}/mdev API path? would make more sense reading the
> API calls description and code. Please do so if you do not really have a strong
> argument against, I do not want another strange API path set in stone.
> 
> It would maybe also make sense to have this local node HW stuff in it's own
> directory, nodes/{node}/hardware/pci (and USB, even it's a bit late for that one).
> Would distinct the storage (client) scan stuff from HW one.

That makes sense. Considering the rest of the 'scan' api is often to
literally "scan" external resources (eg. nfs, cifs). And while it does
give you the view from the node, I find hardware does belong into a
separate category.




More information about the pve-devel mailing list