[pve-devel] [PATCH manager 2/8] api/Ceph: cleanup module usage

[Wolfgang Bumiller]

On Wed, Nov 21, 2018 at 03:40:54PM +0100, Fabian Grünbichler wrote:
> On Wed, Nov 21, 2018 at 11:42:37AM +0100, Thomas Lamprecht wrote:
> > most of this was imported by just copying without veryfing if all is
> > actually required. Some lost it's purpose as we re-used more from our
> > existing module code base (e.g., pve-common) but wasn't actually
> > removed.
> > 
> > As this file includes two perl modules you need to take a bit caution
> > when looking at this, as some things are used in one module but not
> > the other - simple grep'ing at this may give false positives.
> > 
> > Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> > ---
> >  PVE/API2/Ceph.pm | 17 +++--------------
> >  1 file changed, 3 insertions(+), 14 deletions(-)
> > 
> > diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
> > index 23cd9ca8..cd62c040 100644
> > --- a/PVE/API2/Ceph.pm
> > +++ b/PVE/API2/Ceph.pm
> > @@ -532,33 +532,22 @@ package PVE::API2::Ceph;
> >  
> >  use strict;
> >  use warnings;
> > -use File::Basename;
> > +
> >  use File::Path;
> > -use POSIX qw (LONG_MAX);
> > -use Cwd qw(abs_path);
> > -use IO::Dir;
> >  use UUID;
> > -use Net::IP;

We do use Net::IP (ip_is_ipv6) in createmon in this package.

> >  
> > -use PVE::SafeSyslog;
> > -use PVE::Tools qw(extract_param run_command file_get_contents file_read_firstline dir_glob_regex dir_glob_foreach);
> > -use PVE::Exception qw(raise raise_param_exc);
> > -use PVE::INotify;
> > -use PVE::Cluster qw(cfs_lock_file cfs_read_file cfs_write_file);
> > -use PVE::AccessControl;
> > +use PVE::Tools qw(run_command file_get_contents);
> > +use PVE::Cluster;
> >  use PVE::Storage;
> >  use PVE::RESTHandler;
> >  use PVE::RPCEnvironment;
> >  use PVE::JSONSchema qw(get_standard_option);
> > -use JSON;
> >  use PVE::RADOS;
> >  use PVE::CephTools;
> >  use PVE::Network;
> 
> it's (still - not caused by this patch) missing PVE::API2::Storage
> ($add_storage calls it).

PVE::API2::Storage::Config actually ;-)