[pve-devel] [PATCH manager 4/8] CephTools: cleanup module usage

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 21 11:42:39 CET 2018


as done with the api ceph modules:
most of this was imported by just copying without veryfing if all is
actually required. Some lost it's purpose as we re-used more from our
existing module code base (e.g., pve-common) but wasn't actually
removed.

As this file includes two perl modules you need to take a bit caution
when looking at this, as some things are used in one module but not
the other - simple grep'ing at this may give false positives.

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 PVE/CephTools.pm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/PVE/CephTools.pm b/PVE/CephTools.pm
index b104b5e8..1e6271f0 100644
--- a/PVE/CephTools.pm
+++ b/PVE/CephTools.pm
@@ -2,13 +2,10 @@ package PVE::CephTools;
 
 use strict;
 use warnings;
-use File::Basename;
+
 use File::Path;
-use POSIX qw (LONG_MAX);
-use Cwd qw(abs_path);
-use IO::Dir;
 
-use PVE::Tools qw(extract_param run_command file_get_contents file_read_firstline dir_glob_regex dir_glob_foreach);
+use PVE::Tools qw(run_command dir_glob_foreach);
 
 my $ccname = 'ceph'; # ceph cluster name
 my $ceph_cfgdir = "/etc/ceph";
-- 
2.19.1





More information about the pve-devel mailing list