[pve-devel] [PATCH 0/2] return cluster name on successful login if available

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 15 09:33:04 CET 2018


On 11/14/18 3:21 PM, Dominik Csapak wrote:
> On 11/13/18 12:06 PM, Thomas Lamprecht wrote:
>> This two patches fix #233 and #1358 which are somewhat related.
>>
>> The, a bit dusty, #233 requested to have the cluster name returned when getting
>> a ticket. This is useful information for API clients and thus I followed up and
>> return this info, for successful authentications of users with the Sys.Audit
>> privilege on '/'.
>>
>> The second patch, for pve-manager, displays this information also in the UI, as
>> requested by #1358, IMO also a sensible request. A lot of users have multiple
>> clusters and can much easier differentiate between them with this patch.
>>
>> Thomas Lamprecht (1):
>>    fix #233: return cluster name on successful login
>>
>>   PVE/API2/AccessControl.pm | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> Thomas Lamprecht (1):
>>    fix #1358: ui: show clustername besides 'Datacenter' node, if
>>      available
>>
>>   www/manager6/Workspace.js         |  2 ++
>>   www/manager6/tree/ResourceTree.js | 17 +++++++++++++++++
>>   2 files changed, 19 insertions(+)
>>
> 
> works, but maybe we want to remove the name on logout again?
> if not, consider the patches reviewed & tested by me :)
> 

Yes, will send a v2 for the manager part, thanks for looking at this!





More information about the pve-devel mailing list