[pve-devel] applied: [PATCH v3 manager 0/3] added suggested changes
Thomas Lamprecht
t.lamprecht at proxmox.com
Mon Nov 12 12:29:49 CET 2018
On 11/12/18 11:41 AM, Tim Marx wrote:
> since v2:
> I changed the commit history as suggested by thomas and removed all trailing
> whitspaces I found ;)
> Re-added a slightly different message to patch 2/3, to explain the rename.
>
> Tim Marx (3):
> node zfs: added read,write,cksum fields to device tree
> node zfs: added new component to display additional zfs details
> node zfs: added panel to window as container for new components
>
> www/manager6/node/ZFS.js | 108 +++++++++++++++++++++++++++++++++++------------
> 1 file changed, 81 insertions(+), 27 deletions(-)
>
> --
> 2.11.0
>
yes, much nicer, thanks, pulled!
I improved the layout a bit though, and just pushed a miimal change fixing the layout
and enabling autoscrolling on top:
----8<---
diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index 5a609826..d002632f 100644
--- a/www/manager6/node/ZFS.js
+++ b/www/manager6/node/ZFS.js
@@ -387,12 +388,15 @@ Ext.define('PVE.node.ZFSList', {
var devicetree = Ext.create('PVE.node.ZFSDevices', {
title: gettext('Devices'),
nodename: me.nodename,
+ flex: 1,
zpool: zpool
});
var detailsgrid = Ext.create('PVE.node.ZFSStatus', {
layout: 'fit',
nodename: me.nodename,
+ autoScroll: true,
+ flex: 0,
zpool: zpool
});
@@ -406,6 +410,10 @@ Ext.define('PVE.node.ZFSList', {
items:[{
xtype: 'panel',
region: 'center',
+ layout: {
+ type: 'vbox',
+ align: 'stretch'
+ },
items: [detailsgrid, devicetree],
tbar: [{
text: gettext('Reload'),
More information about the pve-devel
mailing list