[pve-devel] [PATCH cluster] api/join: avoid using an IPv6 address as worker task ID

[Thomas Lamprecht]

Am 07/30/2018 um 03:21 PM schrieb Dietmar Maurer:
 > answering myself, you patch looks correct - not passing undef is OK. 
I guess
 > we do not use it for the GUI anyways for clusterjoin tasks?
 >
Yes the parameter name is a bit misleading at first look...
And yes, we did not show the Task ID for clusterjoin in the GUI or use
it in other ways, so this doesn't change anything there.

While it could be indeed nice to show the clustername, as it'd be more
correct - a node joins a cluster not another node - it's a bit of work
and this seemed the less intrusive workaround to allow API joins over
IPv6 for now.

 >> On July 30, 2018 at 3:13 PM Dietmar Maurer <dietmar at proxmox.com> wrote:
 >>
 >>
 >>
 >>
 >>> On July 30, 2018 at 2:31 PM Thomas Lamprecht <t.lamprecht at proxmox.com>
 >>> wrote:
 >>>
 >>>
 >>> We used the hostname of the node over which we joined a cluster as
 >>> worker ID, which is then encoded in it's task UPID - a unique ID with
 >>> encoded information, separated by colons.
 >>> While this is no problem for normal hostnames, or IPv4 addresses, the
 >>> hostname can also be an IPv6 address - which is also separated by
 >>> colons. This throws of the upid_decode method.
 >>
 >> IMHO this is not meant to be an IP address at all - should be always 
a name
 >> instead.