[pve-devel] [PATCH cluster] api/join: avoid using an IPv6 address as worker task ID

[Dietmar Maurer]

answering myself, you patch looks correct - not passing undef is OK. I guess
we do not use it for the GUI anyways for clusterjoin tasks?

> On July 30, 2018 at 3:13 PM Dietmar Maurer <dietmar at proxmox.com> wrote:
> 
> 
> 
> 
> > On July 30, 2018 at 2:31 PM Thomas Lamprecht <t.lamprecht at proxmox.com>
> > wrote:
> > 
> > 
> > We used the hostname of the node over which we joined a cluster as
> > worker ID, which is then encoded in it's task UPID - a unique ID with
> > encoded information, separated by colons.
> > While this is no problem for normal hostnames, or IPv4 addresses, the
> > hostname can also be an IPv6 address - which is also separated by
> > colons. This throws of the upid_decode method.
> 
> IMHO this is not meant to be an IP address at all - should be always a name
> instead.
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel