[pve-devel] applied: [PATCH manager v2 0/4] xtermjs webgui improvements

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Apr 23 10:33:15 CEST 2018


On 4/20/18 3:37 PM, Dominik Csapak wrote:
> this series changes the embedded console to xterm.js for host/container
> (vms still need novnc)
> and adds xtermjs font settings to the gui
> 
> changes from v1:
> * use a map for the consoletypes in Utils
> * forbid negative values for lineHeight
> * add a reset/save button for xtermjs settings
> 
> i left the lineHeight and letterSpacing in there,
> because i think they are helpful (depending on the font)
> and people can still ignore it
> 

applied series, please followup on my 4/4 reply, if it makes
sense to you and isn't to much work.

> Dominik Csapak (4):
>   allow xtermjs to be the default console
>   remove the novnc panels for node/container
>   set the default console in the gui when setting the option
>   add xterm.js settings
> 
>  www/manager6/Utils.js                |  39 +++++++----
>  www/manager6/button/ConsoleButton.js |   6 +-
>  www/manager6/dc/OptionView.js        |  13 ++++
>  www/manager6/lxc/Config.js           |   9 ---
>  www/manager6/node/Config.js          |   8 ---
>  www/manager6/qemu/CmdMenu.js         |   7 +-
>  www/manager6/window/Settings.js      | 131 ++++++++++++++++++++++++++++++++---
>  7 files changed, 170 insertions(+), 43 deletions(-)
> 



More information about the pve-devel mailing list