[pve-devel] [PATCH manager v2 4/4] add xterm.js settings

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Apr 23 10:20:07 CEST 2018


On 4/20/18 3:37 PM, Dominik Csapak wrote:
> this adds font-settings to the 'My Settings'
> window and makes that bigger
> 

Testing behaviour (didn't looked at the code much yet):

Reset/Save button have a small issue, i.e.:
Starting from a completely empty form both are disabled (OK),
if I then dirty a field they both get enabled (OK),
if I manually delete the field again, bringing it back to
it's previous state both buttons stay enabled (wrong).

Also if I dirty it and then press reset the save button
still stay enabled (wrong).

If the rest looks OK I'll apply it nonetheless, this is minor
and can be followed up on.




More information about the pve-devel mailing list