[pve-devel] Long standing bug in "override_for_missing_acs_capabilities.patch"

[Fabian Grünbichler]

On Wed, Apr 18, 2018 at 10:50:10AM +0100, Daniel Boothby wrote:
> Apologies, I have indeed misunderstood it as I didn't realise it took into
> account the previous chunk alterations.
> 
> Is there any way to know which version of the ACS patch is used in the
> current 5.1-3 ISO download of Proxmox? My system needs one of the newest
> ACS patch versions to override the IOMMU groups correctly and 5.1-3 doesn't
> appear to include it. I successfully built from source a month or so back
> (manually correcting a different ACS patch issue that appears to have since
> been corrected), but am hopeful I can move back to the normal releases soon.

it would probably be helpful if you could describe your actual problem
instead of what you think is causing it ;)

the kernel contained in the 5.1-3 iso was built from

f783f68d2cbb581bc42e5f929d68030ff8426d5c: bump version to 4.13-32, bump ABI to 4.13.13-2-pve

the last change of the ACS override patch that was not just a rename /
update of metadata / rebase was

cfe8ba0b247c813c7636995f0cbfada3f798d0ed: fix typo in acs override patch

diff --git a/override_for_missing_acs_capabilities.patch b/override_for_missing_acs_capabilities.patch
index 7052f5a..36e58e1 100644
--- a/override_for_missing_acs_capabilities.patch
+++ b/override_for_missing_acs_capabilities.patch
@@ -121,7 +121,7 @@ index 44e0ff3..32016cb 100644
 +			acs_on_ids[max_acs_id].vendor = val;
 +
 +			p += strcspn(p, ":");
-+			if (*p != ';') {
++			if (*p != ':') {
 +				pr_warn("PCIe ACS invalid ID\n");
 +				goto next;
 +			}