[pve-devel] [PATCH cluster v3 0/7] corosync config parser refactoring and a WIP of QDevice

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Sep 18 10:32:51 CEST 2017


This iteration should address comments from Fabian and Wolfgang
(thanks for those!)

Main change is how I transform arrays to hashes and vice versa in
patch 4 (corosync: transform config to allow easier access), this
saves us not only some lines of codes but should be also faster.

Additional to that a few comments where added/improved and some minor
refactoring happened.

 # Old cover letter below:

First 5 patches should be ready for committing, but the last two are
rather RFC/WIP and for people who'd like to test (easy) qdevice setup
now. But if someone gives them a (high level) review I'd be still
very grateful.
I send them together as they are a bit related and build upon
each other.

cheers,

Thomas Lamprecht (7):
  pvecm: remove Data::Dumper
  pvecm: import often needed run_command
  corosync config parser: move to hash format
  corosync: transform config to allow easier access
  corosync: add atomic_write_conf and cleanup
  WIP: add foreach_member
  WIP: add and delete qdevice

 data/PVE/API2/ClusterConfig.pm                 |   4 +-
 data/PVE/CLI/pvecm.pm                          | 225 +++++++++++++++++++++++--
 data/PVE/Cluster.pm                            |  16 ++
 data/PVE/Corosync.pm                           | 213 ++++++++---------------
 data/test/corosync_configs/multiple-nodes.conf |   6 +-
 data/test/corosync_configs/single-node.conf    |   6 +-
 6 files changed, 312 insertions(+), 158 deletions(-)

-- 
2.11.0





More information about the pve-devel mailing list