[pve-devel] [PATCH manager] fix default text for SCSI Controller Type

[Thomas Lamprecht]

On 09/15/2017 10:45 AM, Thomas Lamprecht wrote:
> On 09/15/2017 10:31 AM, Alwin Antreich wrote:
>> Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
>> ---
>>   www/manager6/Utils.js | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
>> index 0b850977..09e6be90 100644
>> --- a/www/manager6/Utils.js
>> +++ b/www/manager6/Utils.js
>> @@ -194,7 +194,7 @@ Ext.define('PVE.Utils', { utilities: {
>>       render_scsihw: function(value) {
>>       if (!value) {
>> -        return PVE.Utils.defaultText + ' (LSI 53C895A)';
>> +        return PVE.Utils.defaultText + ' (VirtIO SCSI)';
> 
> Shouldn't that be depended on the OSType?
> With l26 (Linux) this is true, but not for Windows or Other types, AFAIK?
> So without this patch Linux VMs get it wrong, with this patch all other,
> both not ideal...
> 
> There is the PVE.qemu.OSDefaults class which could give you this info:
> 
> PVE.qemu.OSDefaults[ostype].scsihw
> 
> (must be still rendered)
> 

Ignore this. I confused it with our OSDefault automagic setting in the
wizard. That one gets set explicitly, so here is then not Default
selected.

Here we may not change this, the backend defaults still always to lsi.


>>       } else if (value === 'lsi') {
>>           return 'LSI 53C895A';
>>       } else if (value === 'lsi53c810') {
>>
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel